Skip to content

[PLT-901] Vb/fix some tests plt 901 #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Jun 6, 2024

Description

This PR includes improvements to 3 tests that should make our sdk integration tests less flaky

  • For test_model_run_split_assignment_by_data_row_ids removed unnecessary project creation and data row import. The task would not COMPLETE under heavy load for this test before
  • test_filtering is a 'consistently' flaky spec. In the past it was failing a lot, I have made some updates and now it failed much less. This new change should hopefully make it stable
  • test_task test_task_success_label_export was pulling incorrect task

Type of change

Please delete options that are not relevant.

  • Test fix (non-breaking change which fixes an issue)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner June 6, 2024 23:21
@vbrodsky vbrodsky merged commit 792f3a9 into develop Jun 11, 2024
19 of 22 checks passed
@vbrodsky vbrodsky deleted the VB/fix-some-tests_PLT-901 branch June 11, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants